[PATCH] D77604: [MachineCSE] Don't carry the wrong location when hoisting

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 6 18:01:36 PDT 2020


aprantl added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineCSE.cpp:839
+        auto EmptyDL = DebugLoc();
+        NewMI.setDebugLoc(EmptyDL);
+
----------------
Can NewMI be a call?
If yes, this should be an artificial location instead, or later inlining of the call will cause an IR verifier failure because the inline location is dropped.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77604/new/

https://reviews.llvm.org/D77604





More information about the llvm-commits mailing list