[PATCH] D77604: [MachineCSE] Don't carry the wrong location when hoisting

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineCSE.cpp:839
+        auto EmptyDL = DebugLoc();
+        NewMI.setDebugLoc(EmptyDL);
+
----------------
davide wrote:
> aprantl wrote:
> > Can NewMI be a call?
> > If yes, this should be an artificial location instead, or later inlining of the call will cause an IR verifier failure because the inline location is dropped.
> I am probably missing the obvious, but this is already MIR. I don't think llvm does any inlining that late in the pipeline.
I completely missed the fact that this is MIR. Sorry.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77604/new/

https://reviews.llvm.org/D77604