[PATCH] D76742: [lld] Add basic symbol table output

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/MachO/Driver.cpp:168-169
   for (InputSection *isec : inputSections) {
     OutputSegment *os =
-        getOrCreateOutputSegment(isec->segname, VM_PROT_READ | VM_PROT_WRITE);
+        getOrCreateOutputSegment(isec->segname);
     isec->parent = os;
----------------
This can now fit to a single line?


================
Comment at: lld/MachO/Writer.cpp:381
+
+// TODO: Implement symbol export trie.
+void Writer::createSymtabContents() {
----------------
Can you add a function comment about the structure fo the symbol table, so that readers can get a sense what this function is supposed to do without reading the code?


================
Comment at: lld/MachO/Writer.cpp:395
+
+  raw_svector_ostream contensOs{linkEditSeg->contents};
+  for (Symbol *sym : symtab->getSymbols()) {
----------------
int3 wrote:
> s/contensOs/contentsOs/
but maybe just `os` is fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76742/new/

https://reviews.llvm.org/D76742