[PATCH] D76742: [lld] Add basic symbol table output

[Kellie Medlin via Phabricator via llvm-commits]

Ktwu marked 6 inline comments as done.
Ktwu added a comment.

Sorry for the delay in response, and thanks for the review so far!



================
Comment at: lld/test/MachO/symtab_basic.s:1
+# REQUIRES: x86
+# RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %s -o %t.o
----------------
int3 wrote:
> naming nits:
> 
> 1) Use hyphens instead of underscores for test names (consistent with other lld tests)
> 2) The "_basic" suffix seems a bit unnecessary since this will (hopefully quickly) become a non-basic test
Sure; I hoped that we could have a series of tests with one sanity test, but I'll happily rename this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76742/new/

https://reviews.llvm.org/D76742