[PATCH] D76649: [X86] Move combineLoopMAddPattern and combineLoopSADPattern to an IR pass before SelecitonDAG.

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In D76649#1944350 <https://reviews.llvm.org/D76649#1944350>, @craig.topper wrote:

> In D76649#1944257 <https://reviews.llvm.org/D76649#1944257>, @spatel wrote:
>
> > There's still 1 other use of the flag in DAGCombiner IIUC, but if we can find a way to get rid of that too, that would be great.
>
>
> Isn't the use in DAGCombiner just a check to prevent reassociation so we don't lose the flag?


Ah, I didn't make that connection. So we can delete that use and the SelectionDAGBuilder code in this patch, or is there some reason to make that a different step?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76649/new/

https://reviews.llvm.org/D76649