[PATCH] D71027: Support repeated machine outlining

[David Tellenbach via Phabricator via llvm-commits]

tellenbach added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineOutliner.cpp:102
+static cl::opt<unsigned>
+    NumRepeat("outline-repeat-count", cl::Hidden,
+              cl::desc("The number of times to apply outlining"), cl::init(1));
----------------
Could we rename this to something like `machine-outline-repeat-counts` or `machine-outline-runs`? The term `outlining` itself is somewhat ambigious and the prefix `machine` would be more consistent.


================
Comment at: llvm/lib/CodeGen/MachineOutliner.cpp:103
+    NumRepeat("outline-repeat-count", cl::Hidden,
+              cl::desc("The number of times to apply outlining"), cl::init(1));
+
----------------
Same here: I suggest something like *...to apply machine outlining*


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71027/new/

https://reviews.llvm.org/D71027