[PATCH] D71027: Support repeated machine outlining

[Jin Lin via Phabricator via llvm-commits]

jinlin marked an inline comment as done.
jinlin added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/machine-outliner-iterative.mir:65-71
+    %tmp4 = alloca [24 x i8], align 8
+    %tmp101 = getelementptr inbounds %10, %10* %tmp11, i64 0, i32 1
+    %tmp103 = bitcast %6* %tmp101 to i8*
+    call void @foo(i8* nonnull %tmp103, [24 x i8]* nonnull %tmp4, i64 33, i8* null)
+    %tmp1042 = bitcast %2* %tmp38 to %0*
+    call void @widget(%0* %tmp1042)
+    ret void
----------------
jinlin wrote:
> paquette wrote:
> > The IR instructions inside each of the IR functions here should not be necessary.
> Please let me know how to make it work. Initially I used those instructions to generate the first iteration machine outlining functions. If I simply remove them, it will not work.
Now I understand what you mean. I have updated the test based on your suggestions. Thank you.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71027/new/

https://reviews.llvm.org/D71027