[PATCH] D71027: Support repeated machine outlining

[David Tellenbach via Phabricator via llvm-commits]

tellenbach added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineOutliner.cpp:1510
+bool MachineOutliner::runOnModule(Module &M) {
+  unsigned NumRepeats = NumRepeat;
+  if (NumRepeats < 1)
----------------
Why is this indirection necessary?


================
Comment at: llvm/test/CodeGen/AArch64/machine-outliner-iterative.mir:1
+# RUN: llc -mtriple=aarch64--- -run-pass=prologepilog -run-pass=machine-outliner -outline-repeat-count=2 -verify-machineinstrs %s -o - | FileCheck %s
+
----------------
Could you run this test with a higher number for `-outline-repeat-count` to verfiy that the outlining stops when no changes are found and nothing changes (beside the name of the outlined functions)?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71027/new/

https://reviews.llvm.org/D71027