[PATCH] D68063: Propeller: LLVM support for basic block sections

[Sriraman Tallam via Phabricator via llvm-commits]

tmsriram added a comment.

In D68063#1913593 <https://reviews.llvm.org/D68063#1913593>, @efriedma wrote:

> In LLVM core libraries, we generally want to accommodate use-cases that don't involve writing files to disk.  This makes it easier to write tools targeting new use-cases.  Here, for example, someone might want to try writing a JIT using a Propeller workflow.  If SampleProfileLoader isn't supporting that, it should probably be fixed.
>
> Mechanically, this seems fine... but it's also okay if we end up with a bit of similar code in multiple places.  llc option parsing vs. lld option parsing is two distinct operations.


Sure, I made the MemoryBuffer a shared_ptr in TargetOptions and moves the IO out of the LLVM core.   The duplicated code in lld and llc is just the getFile and Error check.  Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68063/new/

https://reviews.llvm.org/D68063