[PATCH] D68063: Propeller: LLVM support for basic block sections

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 9 17:17:26 PDT 2020


efriedma added a comment.

In LLVM core libraries, we generally want to accommodate use-cases that don't involve writing files to disk.  This makes it easier to write tools targeting new use-cases.  Here, for example, someone might want to try writing a JIT using a Propeller workflow.  If SampleProfileLoader isn't supporting that, it should probably be fixed.

Mechanically, this seems fine... but it's also okay if we end up with a bit of similar code in multiple places.  llc option parsing vs. lld option parsing is two distinct operations.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68063/new/

https://reviews.llvm.org/D68063





More information about the llvm-commits mailing list