[PATCH] D68063: Propeller: LLVM support for basic block sections

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

> To be clear I think this is close to being acceptable

Agreed. I am still waiting for the resolution to my (very old) comment about:

  namespace BasicBlockSection {
    enum SectionMode {

A scoped enumeration (`enum class`) will be clearer.

The summary is very long and includes lots of stuff not touched by this patch. The relevant paragraphs should be moved to a subsequent patch I think.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68063/new/

https://reviews.llvm.org/D68063