[PATCH] D75203: [X86] Relax existing instructions to reduce the number of nops needed for alignment purposes
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 2 16:55:35 PST 2020
craig.topper added inline comments.
================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp:747
+ // If we have an instruction which hasn't been fully relaxed, we can't
+ // skip past it and insert bytes before it. Changing it's starting
+ // offset might require a larger negative offset than it can encode.
----------------
it's ->its
================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp:770
+
+ // If we're looking at a boundary align, make sure we don't try to pad a
+ // it's target instructions for some following directive. Doing so would
----------------
The end of this line and into the next line doesn't read right. It says "a it's"
================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp:771
+ // If we're looking at a boundary align, make sure we don't try to pad a
+ // it's target instructions for some following directive. Doing so would
+ // break the alignment of the current boundary align.
----------------
it's -> its
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75203/new/
https://reviews.llvm.org/D75203
More information about the llvm-commits
mailing list