[PATCH] D75203: [X86] Relax existing instructions to reduce the number of nops needed for alignment purposes

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 2 16:38:30 PST 2020


reames updated this revision to Diff 247752.
reames retitled this revision from "Relax existing instructions to reduce the number of nops needed for alignment purposes" to "[X86] Relax existing instructions to reduce the number of nops needed for alignment purposes".
reames added a comment.

Give up and just make all the code target specific.  I'd originally hoped to apply this for other targets as well, but when looking at Hexagon (the only one with anything analogous), I realized that forcing a common implementation was just adding complexity for little value.  Each backend has it's own set of constraints as to which padding is valuable.  Instead of introducing new APIs, just follow the precedent that Hexagon already set.

Once this is in and backed a bit, we can revisit to see if any of it can be made target agnostic after all.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75203/new/

https://reviews.llvm.org/D75203

Files:
  llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp
  llvm/test/MC/X86/align-branch-64.s
  llvm/test/MC/X86/align-via-relaxation.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75203.247752.patch
Type: text/x-patch
Size: 11508 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200303/c9092093/attachment.bin>


More information about the llvm-commits mailing list