[PATCH] D75203: [X86] Relax existing instructions to reduce the number of nops needed for alignment purposes

Kan Shengchen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 2 18:04:16 PST 2020


skan added inline comments.


================
Comment at: llvm/test/MC/X86/align-via-relaxation.s:10
+  # CHECK: .text
+  # CHECK: 0: eb 1f                        	jmp 31 <foo>
+  # CHECK: 2: e9 1a 00 00 00               	jmp 26 <foo>
----------------
reames wrote:
> MaskRay wrote:
> > `jmp` is misaligned.
> Er, what?  Are you possibly thinking of the branch-align feature?  That's not enabled in this test file.
I think his meaning is "jmp" is misaligned in a text editor.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75203/new/

https://reviews.llvm.org/D75203





More information about the llvm-commits mailing list