[PATCH] D75369: [mlir][DialectConversion] Abort early if a subregion has a disconnected CFG.
    Matthias Kramm via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Fri Feb 28 11:30:48 PST 2020
    
    
  
matthiaskramm marked an inline comment as done.
matthiaskramm added inline comments.
================
Comment at: mlir/lib/Transforms/DialectConversion.cpp:55
+      for (auto ®ion : op.getRegions()) {
+        auto result = computeConversionSet(region.getBlocks(), region.getLoc(),
+                                           toConvert, target);
----------------
rriddle wrote:
> nit: Just inline this variable.
Good idea, but I can't- it's also used in the return.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75369/new/
https://reviews.llvm.org/D75369
    
    
More information about the llvm-commits
mailing list