[PATCH] D75369: Abort early if a subregion has a disconnected CFG.
    River Riddle via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Fri Feb 28 10:51:41 PST 2020
    
    
  
rriddle added a comment.
Can you please make sure to add a `[mlir]` tag to the beginning of the commit title?
================
Comment at: mlir/lib/Transforms/DialectConversion.cpp:55
+      for (auto ®ion : op.getRegions()) {
+        auto result = computeConversionSet(region.getBlocks(), region.getLoc(),
+                                           toConvert, target);
----------------
nit: Just inline this variable.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75369/new/
https://reviews.llvm.org/D75369
    
    
More information about the llvm-commits
mailing list