[PATCH] D75369: [mlir][DialectConversion] Abort early if a subregion has a disconnected CFG.

[Matthias Kramm via Phabricator via llvm-commits]

matthiaskramm marked an inline comment as done.
matthiaskramm added inline comments.


================
Comment at: mlir/lib/Transforms/DialectConversion.cpp:55
+      for (auto &region : op.getRegions()) {
+        auto result = computeConversionSet(region.getBlocks(), region.getLoc(),
+                                           toConvert, target);
----------------
matthiaskramm wrote:
> rriddle wrote:
> > nit: Just inline this variable.
> Good idea, but I can't- it's also used in the return.
Nm, I see what you mean now. Changing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75369/new/

https://reviews.llvm.org/D75369