[PATCH] D74308: [Debuginfo][NFC] Unify error reporting routines inside DebugInfoDWARF.

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

In D74308#1889316 <https://reviews.llvm.org/D74308#1889316>, @avl wrote:

> Will wait for @grimar comments.


The error handler was implemented in D34328 <https://reviews.llvm.org/D34328> and used in LLD: D34814 <https://reviews.llvm.org/D34814>.
It was needed because when an error happened during parsing a debug data, the code in lib/DebugInfo
just printed something to `errs()` and did not let LLD know about the error (see D34814 <https://reviews.llvm.org/D34814>).
LLD's implementation of `.gdb_index` (that is for what we are using lib/DebugInfo code) changed significantly since that time,
seems LLD does not use D34328 <https://reviews.llvm.org/D34328> code anymore.

In D74308#1889097 <https://reviews.llvm.org/D74308#1889097>, @jhenderson wrote:

> Is it possible this is now dead code? It looks like @grimar originally added it 3 years ago.


It probably might be usefull for people who might want to use `DWARFObjInMemory` class like we had in LLD before.
This error handler was the only good way to know on a caller side that something went wrong during DWARF parsing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74308/new/

https://reviews.llvm.org/D74308