[PATCH] D74308: [Debuginfo][NFC] Unify error reporting routines inside DebugInfoDWARF.

Alexey Lapshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 24 07:35:44 PST 2020


avl added a comment.

Aha, I see. Yes, it looks like it is not used currently. The only place is DWARFDebugInfoTest.cpp which checks for that feature. So it seems like that DWARFContext::defaultErrorHandler could be removed:

  create(const object::ObjectFile &Obj, const LoadedObjectInfo *L = nullptr,
           std::string DWPName = "",
           std::function<void(Error)> RecoverableErrorHandler = WithColor::defaultErrorHandler,
           std::function<void(Error)> WarningHandler = WithColor::defaultWarningHandler);

Will wait for @grimar comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74308/new/

https://reviews.llvm.org/D74308





More information about the llvm-commits mailing list