[PATCH] D74308: [Debuginfo][NFC] Unify error reporting routines inside DebugInfoDWARF.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Right, so I think I see a path forward. I agree with @grimar that we need a way to pass the errors encountered during construction of `DWARFObjInMemory` back to the caller of the constructor (and therefore in turn to the caller of `DWARFContext::create`). However, I do not see a need for the existing continue/halt distinction. It seems harmless (aside from maybe slightly less performant) to continue in all cases. This means that we can change the signature of the callback to `void(Error)`, like the other error callbacks, which in turn means we can use `WithColor::defaultErrorHandler` as the default error handling method instead of `objectFileErrorHandler`, and indeed, allows us therefore to remove the extra argument from the signature of `create` (because we can just use the `RecoverableErrorHandler` argument).

Does that make sense?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74308/new/

https://reviews.llvm.org/D74308