[PATCH] D74471: [AArch64][SVE] Add predicate reinterpret intrinsics

Fri Feb 21 05:47:43 PST 2020

c-rhodes marked 3 inline comments as done.
c-rhodes added inline comments.

================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:3055
+    // Return the reintepret if the cast isn't changing type,
+    // i.e. <n x 16 x i1> -> <n x 16 x i1>
+    if (VT == Op.getOperand(1).getValueType())
----------------
efriedma wrote:
> If the conversion isn't changing the type, do you need a REINTERPRET_CAST at all?
No the reinterpret isn't necessary, I was expecting it to be DAG combined with `performNVCASTCombine` but realised there's a case missing for the reinterpret ISD node where that's invoked. I've updated it so the operand is returned if it's a cast to the same type.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74471/new/

https://reviews.llvm.org/D74471