[PATCH] D72713: [ARM][LowOverheadLoops] Check loop liveouts

[Sam Parker via Phabricator via llvm-commits]

samparker marked an inline comment as done.
samparker added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp:642
+    else if (MO.isDef() && isRegLiveInExitBlocks(&ML, MO.getReg()))
+      LiveOuts.push_back(MO.getReg());
+  }
----------------
yroux wrote:
> Why not returning false here instead of populating a SmallVector and checking for its emptiness later ?
Indeed... I think this needs a rewrite :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72713/new/

https://reviews.llvm.org/D72713