[PATCH] D72713: [ARM][LowOverheadLoops] Check loop liveouts

Yvan Roux via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 17 07:40:46 PST 2020


yroux added a comment.

Hi Sam,

just a comment inlined



================
Comment at: llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp:642
+    else if (MO.isDef() && isRegLiveInExitBlocks(&ML, MO.getReg()))
+      LiveOuts.push_back(MO.getReg());
+  }
----------------
Why not returning false here instead of populating a SmallVector and checking for its emptiness later ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72713/new/

https://reviews.llvm.org/D72713





More information about the llvm-commits mailing list