[PATCH] D74042: [test] Disable the Passes/PluginsTest cases on windows
Nico Weber via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 7 11:40:09 PST 2020
thakis added a comment.
Maybe only disable this in shared library builds?
Also, having a `return()` in a cmake file looks kind of gross to me. (It's a local statement but has a file-global effect, and it's easy to miss. In C, returns are super common, but in cmake they very much aren't [1]) Maybe wrap the rest of the file in the if instead?
1: `git ls-files '*CMake*' | xargs rg -l 'return\('`-- 1 occurrence in clang, 3 in llvm
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74042/new/
https://reviews.llvm.org/D74042
More information about the llvm-commits
mailing list