[PATCH] D74042: [test] Disable the Passes/PluginsTest cases on windows with BUILD_SHARED_LIBS

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo updated this revision to Diff 242814.
mstorsjo marked an inline comment as done.
mstorsjo edited the summary of this revision.
mstorsjo added a comment.

Simplified the check to `if (WIN32)`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74042/new/

https://reviews.llvm.org/D74042

Files:
  llvm/unittests/Passes/CMakeLists.txt


Index: llvm/unittests/Passes/CMakeLists.txt
===================================================================
--- llvm/unittests/Passes/CMakeLists.txt
+++ llvm/unittests/Passes/CMakeLists.txt
@@ -7,6 +7,14 @@
   add_definitions(-DLLVM_ENABLE_PLUGINS)
 endif()
 
+# The plugin expects to not link against the Support and Core libraries,
+# but expects them to exist in the process loading the plugin. This doesn't
+# work with DLLs on Windows (where a shared library can't have undefined
+# references), so just skip this testcase on Windows.
+if (WIN32)
+  return()
+endif()
+
 set(LLVM_LINK_COMPONENTS Support Passes Core)
 add_llvm_unittest(PluginsTests
   PluginsTest.cpp


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74042.242814.patch
Type: text/x-patch
Size: 677 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200206/d2373f17/attachment.bin>