[PATCH] D74042: [test] Disable the Passes/PluginsTest cases on windows

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In D74042#1864714 <https://reviews.llvm.org/D74042#1864714>, @thakis wrote:

> Maybe only disable this in shared library builds?


That's what I did originally, but then @rnk suggested disabling it altogether, as there seemed to be existing efforts not to leave stale test executables if switching shared libs on/off

> Also, having a `return()` in a cmake file looks kind of gross to me. (It's a local statement but has a file-global effect, and it's easy to miss. In C, returns are super common, but in cmake they very much aren't [1]) Maybe wrap the rest of the file in the if instead?
> 
> 1: `git ls-files '*CMake*' | xargs rg -l 'return\('`-- 1 occurrence in clang, 3 in llvm

Sure, I could do that


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74042/new/

https://reviews.llvm.org/D74042