[PATCH] D74042: [test] Disable the Passes/PluginsTest cases on windows with BUILD_SHARED_LIBS

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: llvm/unittests/Passes/CMakeLists.txt:4-5
 
 # If plugins are disabled, this test will disable itself at runtime. Otherwise,
 # reconfiguring with plugins disabled will leave behind a stale executable.
 if (LLVM_ENABLE_PLUGINS)
----------------
It seems there is some prior reason this is done this way, so that reconfiguring a build directory from BUILD_SHARED_LIBS=ON to OFF and back rebuilds the executable. Otherwise lit test discovery will find it.

To this point, I think we should simply disable this whole directory on Windows. (`if (WIN32)`) One cannot switch from win32 to non-win32 in the same directory and expect things to work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74042/new/

https://reviews.llvm.org/D74042