[PATCH] D73994: [InlineCost] Relax bonus restrictions on uninlinable functions

[George Burgess IV via Phabricator via llvm-commits]

george.burgess.iv added a comment.

> Yup - I also don't know of any location caching the cost. I wonder if this was a nerver-realized goal, and whether it is abandoned. May be worth checking with the author of the comment?

Good call -- looks like the comment was added in 9b5c9580e384 around 5 years ago. The commit message says "We're not currently [caching inline costs], but initial results on LTO indicate this will quickly become important," so this sounds like a nice-to-have that was never had.

Removed the cacheable bit of that comment, since I think it's a bit misleading if there's no motion on it.

> This is sort of extension of the 'shouldBeDeferred' check in Inliner.cpp, except that here the caller may not actually be inlined. Blindly eliminating bonus may preventing the callee from being inlined while not actually enabling the caller to be inlined.

Oof, yeah, these look similar, but it's not clear to me if there's a good way to unify them as a part of this patch (or lift this out to there). Lemme poke it a bit and see :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73994/new/

https://reviews.llvm.org/D73994