[PATCH] D73994: [InlineCost] Relax bonus restrictions on uninlinable functions

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added a comment.

In D73994#1858006 <https://reviews.llvm.org/D73994#1858006>, @george.burgess.iv wrote:

> > On the first bullet, I'm trying to find where InlineCost values are cached. Are we doing that?
>
> I don't actually know myself; I got that from above the comment for `CandidateCall`: "The candidate callsite being analyzed. Please do not use this to do analysis in the caller function; we want the inline cost query to be easily cacheable. Instead, use the cover function paramHasAttr."


Yup - I also don't know of any location caching the cost. I wonder if this was a nerver-realized goal, and whether it is abandoned. May be worth checking with the author of the comment?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73994/new/

https://reviews.llvm.org/D73994