[PATCH] D73994: [InlineCost] Relax bonus restrictions on uninlinable functions

Easwaran Raman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 5 11:24:54 PST 2020


eraman added a comment.

DisallowAllBonuses is called only when the callsite or the callee entry is cold. The only reason to make it conditional on caller's inlinability would be for code size improvement.  Among the 3 bonuses disabled in DisallowAllBonuses, only the LastCallToStaticBonus is useful to allow for code size reduction. You don't want to give a single BB bonus or a vector bonus for a cold callee (or a callee at a cold callsite) whose caller is unlikely to be inlined.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73994/new/

https://reviews.llvm.org/D73994





More information about the llvm-commits mailing list