[PATCH] D73752: [SEH] Remove CATCHPAD SDNode and X86::EH_RESTORE MachineInstr

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 3 06:25:20 PST 2020


hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.

I noticed that AArch64 had a lowering for ISD::CATCHPAD before, but lowered just by deleting it?

Seems reasonable to me.



================
Comment at: llvm/lib/Target/X86/X86FrameLowering.cpp:3225
+    MachineFunction &MF, RegScavenger *RS) const {
+  // 32-bit functions have to restore stack pointers when control is transferred
+  // back to the parent function. These blocks are identified as eh pads that
----------------
This is the same comment as in the function below. Maybe it's not really necessary here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73752/new/

https://reviews.llvm.org/D73752





More information about the llvm-commits mailing list