[PATCH] D73752: [SEH] Remove CATCHPAD SDNode and X86::EH_RESTORE MachineInstr
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 4 15:18:55 PST 2020
rnk marked an inline comment as done.
rnk added a comment.
Thanks!
================
Comment at: llvm/lib/Target/X86/X86FrameLowering.cpp:3225
+ MachineFunction &MF, RegScavenger *RS) const {
+ // 32-bit functions have to restore stack pointers when control is transferred
+ // back to the parent function. These blocks are identified as eh pads that
----------------
hans wrote:
> This is the same comment as in the function below. Maybe it's not really necessary here?
I think I duplicated it because it explains the "funclets & 32-bit" condition, but I think this one is unnecessary.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73752/new/
https://reviews.llvm.org/D73752
More information about the llvm-commits
mailing list