[PATCH] D73592: [IRCE] Make IRCE a Function pass.

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/InductiveRangeCheckElimination.cpp:1774
+    Changed |=
+        simplifyLoop(L, &DT, &LI, &SE, nullptr, nullptr,
+                     /*PreserveLCSSA=*/false);
----------------
Why not `PreserveLCSSA = true`?


================
Comment at: llvm/lib/Transforms/Scalar/InductiveRangeCheckElimination.cpp:1776
+                     /*PreserveLCSSA=*/false);
+    Changed |= formLCSSARecursively(*L, DT, &LI, &SE);
+  }
----------------
Should only be called if `simplifyLoop` did something. My suggestion is
  if (simplifyLoop ...) {
    formLCSSA (if that cannot be achieved by setting flag)
    Changed = true;
  }


================
Comment at: llvm/lib/Transforms/Scalar/InductiveRangeCheckElimination.cpp:1811
+    Changed |=
+        simplifyLoop(L, &DT, &LI, &SE, nullptr, nullptr,
+                     /*PreserveLCSSA=*/false);
----------------
Same comments as above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73592/new/

https://reviews.llvm.org/D73592