[PATCH] D73592: [IRCE] Make IRCE a Function pass.

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/InductiveRangeCheckElimination.cpp:1776
+                     /*PreserveLCSSA=*/false);
+    Changed |= formLCSSARecursively(*L, DT, &LI, &SE);
+  }
----------------
mkazantsev wrote:
> Should only be called if `simplifyLoop` did something. My suggestion is
>   if (simplifyLoop ...) {
>     formLCSSA (if that cannot be achieved by setting flag)
>     Changed = true;
>   }
Actually, I am not even sure that a function pass should commit to preserve LCSSA. It is something that only loop passes use.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73592/new/

https://reviews.llvm.org/D73592