[PATCH] D71293: AMDGPU: Generate the correct sequence of code for FDIV32 when correctly-rounded-divide-sqrt is set
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 23 07:34:12 PST 2020
arsenm added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp:122
----------------
Set UseFDivFast once based on the logical expression below and never mutate it. UseFDivFast should be const
================
Comment at: llvm/test/CodeGen/AMDGPU/fdiv.f16.ll:253
+
+!0 = !{float 2.500000e+00}
----------------
I don't know what ulp the f16 rcp instruction provides. This test change looks incomplete if there isn't already a case without !fpmath
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71293/new/
https://reviews.llvm.org/D71293
More information about the llvm-commits
mailing list