[PATCH] D72854: [mlir] Generalize m_ConstantIndexOp

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/include/mlir/IR/Matchers.h:83
+/// The matcher that matches a constant index operation.
+struct constant_index_op_binder {
+  IntegerAttr *bind_value;
----------------
rriddle wrote:
> This is a lot of duplication for what should be one or two lines of code.
I would imagine that the constant_op_binder could optionally constrain the type(using isa<>) as well (via templates).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72854/new/

https://reviews.llvm.org/D72854