[PATCH] D72854: [mlir] Generalize m_ConstantIndexOp

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/test/lib/IR/TestMatchers.cpp:141
+void test3(FuncOp f) {
+  assert(f.getNumArguments() == 1 && "matcher test funcs must have 1 args");
+  auto a = m_Val(f.getArgument(0));
----------------
Drop the assert


================
Comment at: mlir/test/lib/IR/TestMatchers.cpp:143
+  auto a = m_Val(f.getArgument(0));
+  IntegerAttr integerAttrConstantIndex;
+  IntegerAttr integerAttrConstant;
----------------
nit: merge these on one line.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72854/new/

https://reviews.llvm.org/D72854