[PATCH] D72854: [mlir] Generalize m_ConstantIndexOp
River Riddle via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 16 09:07:02 PST 2020
rriddle requested changes to this revision.
rriddle added inline comments.
This revision now requires changes to proceed.
================
Comment at: mlir/include/mlir/IR/Matchers.h:83
+/// The matcher that matches a constant index operation.
+struct constant_index_op_binder {
+ IntegerAttr *bind_value;
----------------
This is a lot of duplication for what should be one or two lines of code.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72854/new/
https://reviews.llvm.org/D72854
More information about the llvm-commits
mailing list