[PATCH] D72461: [AIX][XCOFF] Supporting the ReadOnlyWithRel SectionKnd

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 13 14:48:53 PST 2020


hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1876
+    // have read-only data with relocations placed into a read-only section by
+    // the compiler.
     return DataSection;
----------------
Is seems `SectionKind::isGlobalWriteableData` should be updated in the case where we generate `ReadOnlyWithRel` as read-only unless if we find that the `SectionKind` is what we should change in that case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72461/new/

https://reviews.llvm.org/D72461





More information about the llvm-commits mailing list