[PATCH] D72461: [AIX][XCOFF] Supporting the ReadOnlyWithRel SectionKnd

Digger via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 14 07:15:07 PST 2020


DiggerLin marked 2 inline comments as done.
DiggerLin added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1876
+    // have read-only data with relocations placed into a read-only section by
+    // the compiler.
     return DataSection;
----------------
hubert.reinterpretcast wrote:
> Is seems `SectionKind::isGlobalWriteableData` should be updated in the case where we generate `ReadOnlyWithRel` as read-only unless if we find that the `SectionKind` is what we should change in that case.
1. I am not sure for OS, whether they also have the option for put the ReadOnlyWithRel in the readonly section or not ? this is common part for all the OS .
2. even if when we decide to change the SectionKind::isGlobalWriteableData, we will create  a new patch for it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72461/new/

https://reviews.llvm.org/D72461





More information about the llvm-commits mailing list