[PATCH] D72461: [AIX][XCOFF] Supporting the ReadOnlyWithRel SectionKnd

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 13 14:30:24 PST 2020


hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1874
+  if (Kind.isData() || Kind.isReadOnlyWithRel())
+    // TODO: We maybe put this under option control, because user may want to
+    // have read-only data with relocations placed into a read-only section by
----------------
DiggerLin wrote:
> Xiangling_L wrote:
> > s/maybe/may ?
> thanks,fixed
I'm still seeing "maybe". When saying something is fixed, please be clear if the fixed version is not being posted "immediately".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72461/new/

https://reviews.llvm.org/D72461





More information about the llvm-commits mailing list