[PATCH] D72025: [PM][CG-SCC] Add a helper to update the call graph from SCC passes

Brian Gesiak via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 8 15:28:31 PST 2020


modocache added inline comments.


================
Comment at: llvm/lib/Analysis/CGSCCPassManager.cpp:498
+    SCC &TargetC = *G.lookupSCC(*RefTarget);
+    RefSCC &TargetRC = TargetC.getOuterRefSCC();
+    // TODO: This only allows trivial edges to be added for now.
----------------
You'll need to add a `(void)TargetRC;` statement or something here and on similar lines. In release builds, I'm seeing the following warnings:

```
llvm/lib/Analysis/CGSCCPassManager.cpp:498:13: warning: unused variable 'TargetRC' [-Wunused-variable]
    RefSCC &TargetRC = TargetC.getOuterRefSCC();
            ^
llvm/lib/Analysis/CGSCCPassManager.cpp:508:13: warning: unused variable 'TargetRC' [-Wunused-variable]
    RefSCC &TargetRC = TargetC.getOuterRefSCC();
            ^
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72025/new/

https://reviews.llvm.org/D72025





More information about the llvm-commits mailing list