[PATCH] D72025: [PM][CG-SCC] Add a helper to update the call graph from SCC passes

[Brian Gesiak via Phabricator via llvm-commits]

modocache added inline comments.


================
Comment at: llvm/unittests/Analysis/CGSCCPassManagerTest.cpp:1363
+    ASSERT_DEATH(updateCGAndAnalysisManagerForFunctionPass(CG, C, H2N, AM, UR),
+                 "Any new calls should be modeled as");
+  }));
----------------
jdoerfert wrote:
> modocache wrote:
> > I think this sentence is missing its ending. Basically `TestUpdateCGAndAnalysisManagerForPasses0` is testing that CGSCC passes can insert new edges, and `TestUpdateCGAndAnalysisManagerForPasses1` is testing that function passes cannot -- is that right?
> Yes, correct. The sentence is not an assertion but a regular expression that checks for the assertion.
Aha! Thanks, I didn't know that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72025/new/

https://reviews.llvm.org/D72025