[PATCH] D72025: [PM][CG-SCC] Add a helper to update the call graph from SCC passes

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert marked an inline comment as done.
jdoerfert added inline comments.


================
Comment at: llvm/lib/Analysis/CGSCCPassManager.cpp:498
+    SCC &TargetC = *G.lookupSCC(*RefTarget);
+    RefSCC &TargetRC = TargetC.getOuterRefSCC();
+    // TODO: This only allows trivial edges to be added for now.
----------------
modocache wrote:
> You'll need to add a `(void)TargetRC;` statement or something here and on similar lines. In release builds, I'm seeing the following warnings:
> 
> ```
> llvm/lib/Analysis/CGSCCPassManager.cpp:498:13: warning: unused variable 'TargetRC' [-Wunused-variable]
>     RefSCC &TargetRC = TargetC.getOuterRefSCC();
>             ^
> llvm/lib/Analysis/CGSCCPassManager.cpp:508:13: warning: unused variable 'TargetRC' [-Wunused-variable]
>     RefSCC &TargetRC = TargetC.getOuterRefSCC();
>             ^
> ```
Will do, thanks. (I add WITH_ASSERTS to my release build so I don't see these warnings).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72025/new/

https://reviews.llvm.org/D72025