[PATCH] D71013: [AIX] Allow vararg calls when all arguments reside in registers.

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-cc-altivec.ll:3
+
+; This test expects a compiler diagnostic for an AIX limitation on altivec support.
+; When altivec is enabled, this test should fail to alert the author that this
----------------
While I am partial to using "AltiVec", most instances in the codebase of the word as used in English has it written capitalized (as a proper noun) as "Altivec".


================
Comment at: llvm/test/CodeGen/PowerPC/aix-cc-altivec.ll:4
+; This test expects a compiler diagnostic for an AIX limitation on altivec support.
+; When altivec is enabled, this test should fail to alert the author that this
+; test should be modified and added to the aix calling convention tests.
----------------
The wording is ambiguous as to whether the test should fail (period) or the test should fail to alert. Replace "to" with "in order to".


================
Comment at: llvm/test/CodeGen/PowerPC/aix-cc-altivec.ll:5
+; When altivec is enabled, this test should fail to alert the author that this
+; test should be modified and added to the aix calling convention tests.
+; The AIX calling convention requires that both a FPR and GPR are initialized for the
----------------
"AIX".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71013/new/

https://reviews.llvm.org/D71013