[PATCH] D71013: [AIX] Allow vararg calls when all arguments reside in registers.

[Chris Bowler via Phabricator via llvm-commits]

cebowleratibm marked 7 inline comments as done.
cebowleratibm added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:6832
 
+  if (ValVT.isVector() || !LocVT.isVector())
+    report_fatal_error("Vector arguments are unimplemented on AIX.");
----------------
ZarkoCA wrote:
> I think you should remove the `!`, currently it would error on all types.
Good catch.  I had a typo.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:6887
+    MVT RegVT = IsPPC64 ? MVT::i64 : MVT::i32;
+    for (unsigned i = 0; i < StoreSize; i += PtrByteSize) {
+      if (unsigned Reg = State.AllocateReg(IsPPC64 ? GPR_64 : GPR_32)) {
----------------
ZarkoCA wrote:
> nit: `I` instead of i?
It was 'i' before but I can change it while I'm here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71013/new/

https://reviews.llvm.org/D71013