[PATCH] D71013: [AIX] Allow vararg calls when all arguments reside in registers.
Zarko Todorovski via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 8 06:34:56 PST 2020
ZarkoCA added inline comments.
================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:6832
+ if (ValVT.isVector() || !LocVT.isVector())
+ report_fatal_error("Vector arguments are unimplemented on AIX.");
----------------
I think you should remove the `!`, currently it would error on all types.
================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:6887
+ MVT RegVT = IsPPC64 ? MVT::i64 : MVT::i32;
+ for (unsigned i = 0; i < StoreSize; i += PtrByteSize) {
+ if (unsigned Reg = State.AllocateReg(IsPPC64 ? GPR_64 : GPR_32)) {
----------------
nit: `I` instead of i?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71013/new/
https://reviews.llvm.org/D71013
More information about the llvm-commits
mailing list