[PATCH] D71822: [ELF] Delete the RelExpr member R_HINT. NFC

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 23 11:51:14 PST 2019


MaskRay added inline comments.


================
Comment at: lld/ELF/Arch/RISCV.cpp:232
   case R_RISCV_TPREL_ADD:
-    return R_HINT;
+    return R_NONE;
   default:
----------------
grimar wrote:
> This place deserves a comment then.
@jrtc27 will add it on D71820. Ignoring `R_RISCV_ALIGN` deserves a warning/error.

(For more interesting problems, see D70157 how this can be risky in a few constructs (I'd say in 99% cases they are probably fine))


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71822/new/

https://reviews.llvm.org/D71822





More information about the llvm-commits mailing list