[PATCH] D71822: [ELF] Delete the RelExpr member R_HINT. NFC

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 23 01:20:03 PST 2019


grimar added a comment.

I think this is fine, but would like to hear what others think.



================
Comment at: lld/ELF/Arch/RISCV.cpp:232
   case R_RISCV_TPREL_ADD:
-    return R_HINT;
+    return R_NONE;
   default:
----------------
This place deserves a comment then.


================
Comment at: lld/ELF/Relocations.cpp:1255
+  // Ignore R_*_NONE and marker relocations.
+  if (oneof<R_NONE>(expr))
     return;
----------------
`if (expr == R_NONE)` ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71822/new/

https://reviews.llvm.org/D71822





More information about the llvm-commits mailing list