[PATCH] D71202: [test][llvm-cxxfilt] Fix darwin build bot/improve test naming and commenting

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 9 08:06:33 PST 2019


jhenderson marked an inline comment as done.
jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-cxxfilt/strip-underscore-default.test:8
+CHECK: __Z1fv
+CHECK: ba()
----------------
compnerd wrote:
> Can you merge this into the previous test and use -triple to test the defaults?  That ensures that the tests always run and people on other hosts can validate that they do not regress tins things.
Sounds reasonable. I'll see what I can figure out with that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71202/new/

https://reviews.llvm.org/D71202





More information about the llvm-commits mailing list